Starling Protocol Bug in STATS Response

July 18th, 2008

The memcache protocol requires that all lines in the server response end with CRLN (\r\n). The Starling server doesn’t strictly obey this for the STATS command. The fix is trivial and the author has been notified of the fix.

Edit lib/starling/handler.rb and add the following gsub right before .freeze in the STATS_RESPONSE:

%sEND\r\n”.gsub(/\r?\n/, “\r\n”).freeze

And the same for QUEUE_STATS_RESPONSE:

STAT queue_%s_expired_items %d\n”.gsub(/\r?\n/, “\r\n”).freeze

add to del.icio.us    add to technorati favs    email this

Posted in uncategorized |

2 Responses to “Starling Protocol Bug in STATS Response”

1. Dieter_be Says:
   September 3rd, 2008 at 1:24 pm

   Hi,
   I never heard of Starling (until now) but you could check if it supports the memcached binary protocol. Using this protocol (developed by the facebook guys iirc) is easier on your cpu’s.

   Really like your blog btw (came here searching for a php class for mogileFS )

2. e Says:
   September 3rd, 2008 at 1:40 pm

   No, it does not support the binary protocol or UDP. It’s open source, however, so it doesn’t prevent someone else from implementing it.

   I would start off with seeing how well it performs for you. We’re able to do a couple thousand inserts per second on a slow machine (ec2 m1.small instance).

   Also note, the current version of Starling in git has fixed the bug mentioned in this post.

Leave a Reply